Commit Graph
13619 Commits
Author SHA1 Message Date
Darafei Praliaskouski 56e73cd804 ci: avoid rsync dependency in NetBSD VM jobs 2026-05-11 18:16:59 +10:00
[email protected] ac4a41265a upstream: unbreak; spotted by Darren's test army
OpenBSD-Commit-ID: e95ceda842a2c7a08fc00ac3a529877d87fee7b2
2026-05-05 16:23:36 +10:00
[email protected] 3754f2edd4 upstream: classify dynamic-tcpip channels as bulk, not interactive;
bz3958, ok markus@

OpenBSD-Commit-ID: b18f1c1eaff8423bf069ff6103e8865cec18d64b
2026-05-05 15:35:28 +10:00
Darren Tucker 4ea08a0353 Improve NetBSD PAM tests.
- Set random password and use for password auth test.
 - When testing PAM builds, test with and without UsePAM.
2026-05-05 00:09:12 +10:00
Darren Tucker 504d01d81f Improve FreeBSD PAM tests.
- Set random password and use for password auth test.
 - When testing PAM builds, test with and without UsePAM.
2026-05-05 00:09:11 +10:00
Darren Tucker a05de3f67f Update to FreeBSD 14.4, add 15.0. 2026-05-05 00:09:11 +10:00
Darren Tucker 6296749fe1 Improve Solaris PAM tests.
- Set up and run tests with SUDO.
 - Set random password to use for password & kbdint auth tests.
 - Only run t-exec when re-testing with PAM, don't rerun unit tests.
 - When testing PAM builds, test with and without UsePAM.
2026-05-05 00:09:07 +10:00
Darren Tucker f9d62eaa53 Only run t-exec when re-testing with PAM.
There's no point rerunning unit tests.
2026-05-05 00:09:06 +10:00
Darren Tucker 05af6553e9 Add Solaris 11.4-clang-19 test. 2026-05-05 00:09:05 +10:00
Darren Tucker cb654c2ce7 Add RUN_ONLY_PLATFORM to run a subset of tests. 2026-05-05 00:09:05 +10:00
Damien Miller 328993c899 skip ("#if 0") strvisx and stravis
we don't use the in OpenSSH and some compilers throw warnings
compiling them that break -Werror
2026-05-04 16:05:34 +10:00
Darren Tucker 5fa60ae0d2 Remove 9.9 and 10.0 branches from build status page. 2026-05-01 09:19:56 +10:00
Renaud Allard 7ab5e4073a vm.yml: fix solaris PAM tests
Add missing SSHD_CONFOPTS="UsePam yes" to the solaris PAM test
step so it actually tests PAM functionality instead of re-running
the default tests with a PAM-enabled binary.
2026-04-30 09:28:17 +10:00
[email protected] 1c553a1606 upstream: fiddle with mask after umask call and not before; avoids
fortify warnings on android. bz3954

OpenBSD-Commit-ID: 82224426b2ee989c68f305caa50aa3d3b4993a84
2026-04-30 08:23:32 +10:00
[email protected] 1bfe4ce37c upstream: unveil the actual listening socket path and its directory
so it can be cleaned up at exit.

Reported by / tested by David Krause, ok markus@

OpenBSD-Commit-ID: b45d740e9a63dec0fad436ed78f6912b39f0cd53
2026-04-30 08:23:32 +10:00
[email protected] f24dc9e993 upstream: Clarify comment on what setting extended types for
channels does

OK djm@

OpenBSD-Commit-ID: fa035fb19b74571992fa3adca4396a4c572a7a8a
2026-04-30 08:23:31 +10:00
Darren Tucker b9ccca0edf Add tracking for 10.3 branch. 2026-04-29 09:14:31 +10:00
Darren Tucker 6185d1e6f7 Rename obsd arm64 snapshot VM for consistency. 2026-04-28 09:10:44 +10:00
[email protected] 2029eddf4d upstream: Use supported hostkeyalgorithms specifically in
sshd_config instead of supported key types, which is almost but not
completely correct.

OpenBSD-Regress-ID: 43c3b348576900f3e710bff5d6a87f0e803c5b3d
2026-04-27 21:57:25 +10:00
[email protected] ff254f6740 upstream: Drop -Winline from CDIAGFLAGS it breaks on sparc64
On sparc64 ssh/unittests/kex fails to build with:
 usr.bin/ssh/libcrux_mlkem768_sha3.h:8196: warning: inlining failed
 in call to 'libcrux_ml_kem_polynomial_ZERO_89_ea':
 --param max-inline-insns-single limit reached

OK djm@ (long time ago) reminded by tb@

OpenBSD-Regress-ID: c32094e3436536474039a4aeefabdbf0bd826554
2026-04-27 21:57:24 +10:00
Darren Tucker 2be9cec2fc Update OpenSSL tested versions. 2026-04-27 21:53:36 +10:00
Darren Tucker b41203e500 Comment out new PAM valgrind test until debugged. 2026-04-27 21:47:55 +10:00
Darren Tucker 4e0d1aea89 Simplify Cygwin permissions setting. 2026-04-27 21:47:50 +10:00
Darren Tucker 6c5235cb66 Reorder steps to change perms before displaying. 2026-04-27 21:47:49 +10:00
Darren Tucker ba110a56a7 Allow setting TEST_SSH_TRACE via Github. 2026-04-27 21:47:48 +10:00
Darren Tucker 8751cd9c5c Add tests for libressl-4.3.1. 2026-04-27 21:47:47 +10:00
Darren Tucker 1afbd7bd1f Re-enable SHA1 sigs in OpenSSL on Cygwin for tests.
Recently Cygwin imported changes from Fedora which disable SHA1
signatures by default.  This breaks the unit tests (and a couple of
regression tests), so set rh-allow-sha1-signatures=yes in the OpenSSL
config to re-enable them.
2026-04-27 21:47:46 +10:00
Darren Tucker 7235471fb4 Check for OPENSSL_NO_ENGINE for --with-ssl-engine.
OpenSSL 4 removes support for ENGINE, but it provides no-op stubs
for the ENGINE functions in addition to setting OPENSSL_NO_ENGINE.

The presence of the stubs fooled the old configure test, so if someone
tried --with-ssl-engine with OpenSSL 4.0.0 it'd try but fail at build
time.  Explicitly check for OPENSSL_NO_ENGINE. before trying to enable
ENGINE support.  bz#3952.
2026-04-25 20:00:38 +10:00
[email protected] 45b30e0a54 upstream: correctly set extended type for client-side channels.
Fixes interactive vs bulk IPQoS for client->server traffic. ok job@

OpenBSD-Commit-ID: 34f5131face8d6dc4ae6955196e5fcafb3570cfe
2026-04-20 09:38:26 +10:00
[email protected] ca19b95ab6 upstream: Also show the duration of the current session through the
~I escape

OK dtucker@

OpenBSD-Commit-ID: 695c1a09c4cc8b417a1bd3eb207b0cc7fa831c7a
2026-04-20 09:38:25 +10:00
[email protected] 00d955cf9e upstream: want stdint.h here now that we've switched from u_intXX_t
-> uintXX_t

OpenBSD-Commit-ID: 6d5e80bd6f29a9db18b18beeb1cbe5423b59de44
2026-04-20 09:38:25 +10:00
Bob Beck eb34f95206 Make ci work for OpenSSL 4 variants 2026-04-17 17:44:06 +10:00
Darren Tucker 713ec5c5ae Test against OpenSSL 3.6.2, 4.0.0 and 4.0-stable. 2026-04-16 20:55:23 +10:00
Dmitry Misharov b6d46558db account newer openssl versions in .github/setup_ci.sh 2026-04-16 19:35:04 +10:00
Darren Tucker f2da6737e2 Match case with other messages. 2026-04-16 19:32:34 +10:00
Damien Miller b433d015a6 regen signature on allowed_signers file
This was missed after the file was updated, but nobody noticed it
until now.
2026-04-15 08:14:58 +10:00
Damien Miller 4168c90594 depend 2026-04-02 18:56:48 +11:00
Damien Miller f8b9d694fc Update versions in RPM spec files 2026-04-02 18:55:50 +11:00
[email protected] 5aa09926fb upstream: adapt to username validity check change
OpenBSD-Regress-ID: d22c66ca60f0d934a75e6ca752c4c11b9f4a5324
2026-04-02 18:53:45 +11:00
[email protected] eb3a5bb2ab upstream: openssh-10.3
OpenBSD-Commit-ID: 05e22de74e090e5a174998fa5799317d70ad19c4
2026-04-02 18:53:33 +11:00
[email protected] 76685c9b09 upstream: move username validity check for usernames specified on
the commandline to earlier in main(), specifically before some contexts where
a username with shell characters might be expanded by a %u directive in
ssh_config.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We continue to recommend against using untrusted input on
the SSH commandline. Mitigations like this are not 100%
guarantees of safety because we can't control every
combination of user shell and configuration where they are
used.

Reported by Florian Kohnhäuser

OpenBSD-Commit-ID: 25ef72223f5ccf1c38d307ae77c23c03f59acc55
2026-04-02 18:53:25 +11:00
[email protected] fd1c7e131f upstream: correctly match ECDSA signature algorithms against
algorithm allowlists: HostKeyAlgorithms, PubkeyAcceptedAlgorithms and
HostbasedAcceptedAlgorithms.

Previously, if any ECDSA type (say "ecdsa-sha2-nistp521") was
present in one of these lists, then all ECDSA algorithms would
be permitted.

Reported by Christos Papakonstantinou of Cantina and Spearbit.

OpenBSD-Commit-ID: c790e2687c35989ae34a00e709be935c55b16a86
2026-04-02 18:53:25 +11:00
[email protected] 487e8ac146 upstream: when downloading files as root in legacy (-O) mode and
without the -p (preserve modes) flag set, clear setuid/setgid bits from
downloaded files as one might expect.

AFAIK this bug dates back to the original Berkeley rcp program.

Reported by Christos Papakonstantinou of Cantina and Spearbit.

OpenBSD-Commit-ID: 49e902fca8dd933a92a9b547ab31f63e86729fa1
2026-04-02 18:53:24 +11:00
[email protected] c805b97b67 upstream: add missing askpass check when using
ControlMaster=ask/autoask and "ssh -O proxy ..."; reported by Michalis
Vasileiadis

OpenBSD-Commit-ID: 8dd7b9b96534e9a8726916b96d36bed466d3836a
2026-04-02 18:53:24 +11:00
[email protected] 78d549857e upstream: Fix possible sshd crash when sshd_config set MaxStartups
to a value <10 using the single-argument form of MaxStartups (e.g.
MaxStartups=3). This doesn't affect the three-argument form of the directive
(e.g. MaxStartups 3:20:5).

Patch from Peter Kaestle via bz3941

OpenBSD-Commit-ID: 1ad093cae69f55ebfdea1ab24318aefd593d63b8
2026-04-02 18:53:23 +11:00
Damien Miller 5d72f1865b properly bail out when PAM changes username
OpenSSH doesn't support PAM changing its conception of the
username via a module calling pam_set_item(h, PAM_USER, ...).
We were supposed to bail out here, but I messed up while "fixing"
this last time and dropped a return statement.

Reported by Mike Damm
2026-04-02 18:32:00 +11:00
Michael Forney fe86c39751 avoid k suffix in dd count operand in sftp-resume test
Not all dd implementations support this. POSIX only specifies
suffixes for block size operands.

Instead, just use 1024k to avoid the special case. This also removes
an incorrect redirection operator that appeared in the 1m case.
2026-04-01 16:51:50 +11:00
Michael Forney 52c01f2a80 add missing <stdio.h> include to unit tests for printf
This fixes the build with --without-openssl on musl. glibc worked
previously because it got stdio.h implicitly through resolv.h.
2026-03-31 16:33:20 +11:00
Darren Tucker 1340d3fa8e Add proxyjump.sh omitted from previous commit. 2026-03-30 21:58:44 +11:00
[email protected] 607bd871ec upstream: add a regression test for ProxyJump/-J; ok dtucker
OpenBSD-Regress-ID: 400dc1b5fb7f2437d0dfbd2eb9a3583dafb412b3
2026-03-30 18:51:26 +11:00